-
Notifications
You must be signed in to change notification settings - Fork 582
[Rule Tuning] Added Kubernetes Domain Tag #4831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
⛔️ Test failed Results
|
@@ -49,6 +49,7 @@ severity = "medium" | |||
tags = [ | |||
"Domain: Endpoint", | |||
"Domain: Container", | |||
"Domain: Kubernetes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"I think" K8s would be considered cloud workloads or containers, but no objection to having it be a root domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, the reason I put it as a seperate domain as well, is because we have several BBRs and DRs leveraging Defend, and several DRs leveraging the kubernetes integration. It is a widely used service, so it makes life easy finding these rules if we add it to a domain.
Starting the rule tests ... |
Summary
I noticed we have Kubernetes Domain tags available, so I will add this tag to the kubernetes/kubectl related rules to ensure customers can easily find all rules related to k8s within the Linux ruleset.